linux-kernel - Re: Nokia N900: Broken lirc ir-rx51 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 15:21:11 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Aaro Koskinen <aaro.koskinen@....fi>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Pavel Machel <pavel@....cz>, Nishanth Menon <nm@...com>,
	Timo Kokkonen <timo.t.kokkonen@....fi>,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Nokia N900: Broken lirc ir-rx51 driver

* Pali Rohár <pali.rohar@...il.com> [160422 06:50]:
> On Tuesday 05 January 2016 17:12:50 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@...il.com> [160105 02:19]:
> > > On Saturday 02 January 2016 09:06:57 Tony Lindgren wrote:
> > > >
> > > > Yup please take a look at thread "[PATCH 0/3] pwm: omap: Add PWM support
> > > > using dual-mode timers". Chances are we still need to set up the dmtimer
> > > > code to provide also irqchip functions. That way ir-rx51.c can just do
> > > > request_irq on the selected dmtimer for interrupts.
> > > 
> > > No I see that patch from that thread uses dmtimer.h from plat-omap. So
> > > it is really OK?
> > 
> > It's using the header to populate the platform data in mach-omap2 so
> > that's fine. But we do not want to directly expose the dmtimer functions
> > to device drivers as they are not Linux generic at this point.
>
> Hi Tony! Is there any progress for ir-rx51 driver? Months ago we were
> waiting for some omap pwm patches... What is current state?

Sorry it will be slow going for this one.. I think we should initially
just make it use include/linux/platform_data/pwm_omap_dmtimer.h and
pdata-quirks.c. It seems we need to add few new functions there.

Then once it's working again, we can continue to make it use hrtimer
for one of the gptimers. Then after that it should be easy to change
it to use the PWM framework with the pwm_omap_dmtimer.

Regards,

Tony