linux-kernel - Re: [PATCH] irq_poll: Remove redundant barrier when using clear_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <571E98B9.40900@sandisk.com>
Date:	Mon, 25 Apr 2016 15:22:49 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Davidlohr Bueso <dave@...olabs.net>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Davidlohr Bueso" <dbueso@...e.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mingo@...nel.org" <mingo@...nel.org>
Subject: Re: [PATCH] irq_poll: Remove redundant barrier when using
 clear_bit_unlock()

On 04/19/2016 09:23 PM, Davidlohr Bueso wrote:
> On Tue, 19 Apr 2016, Bart Van Assche wrote:
>
>> On 04/16/2016 01:55 PM, Davidlohr Bueso wrote:
>>> ... as the call obviously already implies unlock/RC semantics,
>>> therefore lets get rid of the superfluous smp_mb calls.
>>
>> Hello Davidlohr,
>>
>> Are you sure that this patch has been sent to the right person? I have
>> helped to review a change in this code but I'm not the maintainer of
>> this code.
>
> Ah, adding Andrew and Ingo, not sure who is responsible for these bits.

Please also CC Jens Axboe and Christoph Hellwig. Jens is the original 
author of this code. See also "block: add blk-iopoll, a NAPI like 
approach for block devices" 
(https://groups.google.com/forum/#!topic/linux.kernel/aMhcMrYaXC8).

Bart.