linux-kernel - Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1604250950380.3941@nanos>
Date:	Mon, 25 Apr 2016 09:52:22 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jan Beulich <JBeulich@...e.com>
cc:	"H. Peter Anvin" <hpa@...or.com>, bp@...en8.de,
	luto@...capital.net, david.vrabel@...rix.com, brgerst@...il.com,
	toshi.kani@...com, peterz@...radead.org, mingo@...nel.org,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	xen-devel@...ts.xenproject.org, boris.ostrovsky@...cle.com,
	dvlasenk@...hat.com, vkuznets@...hat.com,
	Juergen Gross <JGross@...e.com>,
	Luis Rodriguez <Mcgrof@...e.com>, linux-kernel@...r.kernel.org,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

On Mon, 25 Apr 2016, Jan Beulich wrote:
> >>> On 22.04.16 at 20:03, <hpa@...or.com> wrote:
> >> +#define hugepages_supported() cpu_has_pse
> >>  
> > 
> > Please don't use the cpu_has_* macros anymore, they are going away soon.
> > 
> > In this case it should be static_cpu_has(X86_FEATURE_PSE).
> 
> I can certainly do that, but this
> - will (mildly) harm backportability
> - imo should have been requested much earlier (when the patch was
>   still under discussion)

It's requested now as cpu_has_* is going away. So instead of making silly
arguments you should have sent a delta patch fixing this.

Thanks,

	tglx