linux-kernel - Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <571DE56B02000078000E5213@prv-mh.provo.novell.com>
Date:	Mon, 25 Apr 2016 01:37:47 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	<bp@...en8.de>, <luto@...capital.net>, <david.vrabel@...rix.com>,
	<brgerst@...il.com>, <toshi.kani@...com>, <peterz@...radead.org>,
	<mingo@...nel.org>, <tglx@...utronix.de>,
	<akpm@...ux-foundation.org>, <torvalds@...ux-foundation.org>,
	<xen-devel@...ts.xenproject.org>, <boris.ostrovsky@...cle.com>,
	<dvlasenk@...hat.com>, <vkuznets@...hat.com>,
	"Juergen Gross" <JGross@...e.com>,
	"Luis Rodriguez" <Mcgrof@...e.com>, <linux-kernel@...r.kernel.org>,
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

>>> On 22.04.16 at 20:03, <hpa@...or.com> wrote:
> On 04/22/2016 02:47 AM, tip-bot for Jan Beulich wrote:
>> Commit-ID:  103f6112f253017d7062cd74d17f4a514ed4485c
>> Gitweb:     
> http://git.kernel.org/tip/103f6112f253017d7062cd74d17f4a514ed4485c 
>> Author:     Jan Beulich <JBeulich@...e.com>
>> AuthorDate: Thu, 21 Apr 2016 00:27:04 -0600
>> Committer:  Ingo Molnar <mingo@...nel.org>
>> CommitDate: Fri, 22 Apr 2016 10:05:00 +0200
>> 
>> 
>> diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h
>> index f8a29d2..e6a8613 100644
>> --- a/arch/x86/include/asm/hugetlb.h
>> +++ b/arch/x86/include/asm/hugetlb.h
>> @@ -4,6 +4,7 @@
>>  #include <asm/page.h>
>>  #include <asm-generic/hugetlb.h>
>>  
>> +#define hugepages_supported() cpu_has_pse
>>  
> 
> Please don't use the cpu_has_* macros anymore, they are going away soon.
> 
> In this case it should be static_cpu_has(X86_FEATURE_PSE).

I can certainly do that, but this
- will (mildly) harm backportability
- imo should have been requested much earlier (when the patch was
  still under discussion)

Jan