linux-kernel - Re: [PATCH 4/4] ARM: remove duplicate const qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 06:59:14 -0400
From:	Sylvain Lemieux <slemieux.tyco@...il.com>
To:	Eric Engestrom <eric.engestrom@...tec.com>
Cc:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Tony Lindgren <tony@...mide.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Lee Jones <lee.jones@...aro.org>,
	Roland Stigge <stigge@...com.de>,
	Florian Fainelli <f.fainelli@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Alexander Shiyan <shc_work@...l.ru>,
	Kevin Hilman <khilman@...nel.org>,
	Viresh Kumar <vireshk@...nel.org>,
	bcm-kernel-feedback-list@...adcom.com,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	spear-devel@...t.st.com, Ray Jui <rjui@...adcom.com>,
	Rajendra Nayak <rnayak@...com>, Sekhar Nori <nsekhar@...com>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Gregory Fong <gregory.0xf0@...il.com>,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Paul Walmsley <paul@...an.com>,
	Scott Branden <sbranden@...adcom.com>,
	Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	linux-kernel@...r.kernel.org, Sascha Hauer <kernel@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>, vz@...ia.com
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier

Hi Eric,

On Mon, 2016-04-25 at 11:57 +0200, Alexandre Belloni wrote:
> Hi,
> 
> this requires a commit message.
> 
> Also, you should think about separating those changes in multiple patches
> to ease inclusion in the kernel.
> 
> On 25/04/2016 at 10:47:57 +0100, Eric Engestrom wrote :
> > Signed-off-by: Eric Engestrom <eric.engestrom@...tec.com>
> > ---
> >  arch/arm/mach-at91/pm.c                 | 2 +-
> >  arch/arm/mach-bcm/bcm_kona_smc.c        | 2 +-
> >  arch/arm/mach-clps711x/board-autcpu12.c | 2 +-
> >  arch/arm/mach-cns3xxx/core.c            | 2 +-
> >  arch/arm/mach-davinci/da8xx-dt.c        | 2 +-
> >  arch/arm/mach-lpc32xx/phy3250.c         | 2 +-
> >  arch/arm/mach-mxs/mach-mxs.c            | 2 +-
> >  arch/arm/mach-omap2/prm_common.c        | 2 +-
> >  arch/arm/mach-omap2/vc.c                | 2 +-
> >  arch/arm/mach-spear/time.c              | 2 +-
> >  10 files changed, 10 insertions(+), 10 deletions(-)
> > 
...

> > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> > index b2f9e22..1ae7230 100644
> > --- a/arch/arm/mach-lpc32xx/phy3250.c
> > +++ b/arch/arm/mach-lpc32xx/phy3250.c
> > @@ -159,7 +159,7 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
> >  	.dma_filter = pl08x_filter_id,
> >  };
> >  
> > -static const struct of_dev_auxdata const lpc32xx_auxdata_lookup[] __initconst = {
> > +static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
> >  	OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
> >  	OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
> >  	OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),

A patch was already submitted for the LPC32xx:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/493312/

...
> > -- 
> > 2.7.4
> > 
> 
Sylvain