linux-kernel - Re: [PATCH 4/4] ARM: remove duplicate const qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4641918.pNBP5iAK01@wuerfel>
Date:	Mon, 25 Apr 2016 13:38:18 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Eric Engestrom <eric.engestrom@...tec.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Tony Lindgren <tony@...mide.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Lee Jones <lee.jones@...aro.org>,
	Roland Stigge <stigge@...com.de>,
	Florian Fainelli <f.fainelli@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Alexander Shiyan <shc_work@...l.ru>,
	Kevin Hilman <khilman@...nel.org>,
	Viresh Kumar <vireshk@...nel.org>,
	bcm-kernel-feedback-list@...adcom.com,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	spear-devel@...t.st.com, Ray Jui <rjui@...adcom.com>,
	Rajendra Nayak <rnayak@...com>, Sekhar Nori <nsekhar@...com>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Gregory Fong <gregory.0xf0@...il.com>,
	linux-omap@...r.kernel.org, Paul Walmsley <paul@...an.com>,
	Scott Branden <sbranden@...adcom.com>,
	Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	linux-kernel@...r.kernel.org, Sascha Hauer <kernel@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier

On Monday 25 April 2016 11:39:11 Eric Engestrom wrote:
> On Mon, Apr 25, 2016 at 11:57:15AM +0200, Alexandre Belloni wrote:
> > Hi,
> > 
> > this requires a commit message.
> 
> OK? This seems rather pointless in this case (and even more so for the
> typo fix I sent yesterday), but I guess you have some general rule to
> enforce. Would this do then?
> "The second `const` is unnecessary, and is simply ignored by most compilers."

Maybe say you you found it (llvm, sparse, coccinelle?), and why this
is causing a problem for anyone. If it's just unnecessary but not
harmful, I'd probably ignore the patch.

> > Also, you should think about separating those changes in multiple patches
> > to ease inclusion in the kernel.
> 
> I'll resend patch #4 as multiple patches. What the way proper to convey
> that *multiple* new patches replace *one* old one? Is it enough to just
> send those as a reply to this one?

That's fine. Having multiple patches here is slightly better than just
one, but I'd also be fine with just taking the large patch because it
is an identical trivial change in multiple files.

	Arnd