linux-kernel - Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160426154313.GA3217@sirena.org.uk>
Date:	Tue, 26 Apr 2016 16:43:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Andreas Dannenberg <dannenberg@...com>
Cc:	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital
 amplifier

On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote:

This looks mostly good, a few small things below.

> +	switch (width) {
> +	case 16:
> +	case 18:
> +	case 20:
> +	case 24:
> +		/*
> +		 * We only support the different left-justified serial audio
> +		 * formats in which case there is nothing to configure in the
> +		 * TAS5720.
> +		 */
> +		break;
> +	default:
> +		dev_err(codec->dev, "unsupported sample size: %d\n", width);
> +		return -EINVAL;
> +	}

If the driver doesn't do anything just remove the code.

> +	if ((curr_fault & TAS5720_OCE) && !(tas5720->last_fault & TAS5720_OCE))
> +		dev_warn(dev, "The Class-D output stage has experienced an over current event\n");

"Class D over current".  The verbosity is making the line over long and
the phrasing is a bit unclear (and makes it seem less critical than it
really is).  These should probably be dev_crit() or somthing too, over
current and similar events on a speaker output are generally extremely
serious.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)