linux-kernel - [PATCH] i2c-mux-pca9541: fix setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1604272105150.2043@localhost6.localdomain6>
Date:	Wed, 27 Apr 2016 21:06:47 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Corey Minyard <cminyard@...sta.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Wolfram Sang <wsa@...-dreams.de>
cc:	kbuild-all@...org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] i2c-mux-pca9541: fix setup_timer.cocci warnings

Use setup_timer function instead of initializing timer with the function
and data fields

Generated by: scripts/coccinelle/api/setup_timer.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

tree:   git://git.code.sf.net/p/openipmi/linux-ipmi v4.5-ipmi
head:   671fec027e30fdac67b341f0271841f02db0a027
commit: 4a199ab1bf7b7a2b5f7e0b0eb4162b4e98b9cd7f [25/33] i2c-mux-pca9541: 
Add support for non-blocking handling

 i2c-mux-pca9541.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -547,9 +547,7 @@ static int pca9541_probe(struct i2c_clie
 	data->op_e.smbus.data = &data->op_data;
 	data->op_e.smbus.size = I2C_SMBUS_BYTE_DATA;
 
-	init_timer(&data->timer);
-	data->timer.data = (unsigned long) data;
-	data->timer.function = pca9541_timeout;
+	setup_timer(&data->timer, pca9541_timeout, (unsigned long)data);
 
 	/*
 	 * I2C accesses are unprotected here.