linux-kernel - Re: [PATCH 00/12] De-stage Sync File Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 21:09:15 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Gustavo Padovan <gustavo@...ovan.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	dri-devel@...ts.freedesktop.org,
	Daniel Stone <daniels@...labora.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robdclark@...il.com>,
	Greg Hackmann <ghackmann@...gle.com>,
	John Harrison <John.C.Harrison@...el.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [PATCH 00/12] De-stage Sync File Framework

On Wed, Apr 27, 2016 at 01:27:07PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> 
> Hi,
> 
> This patchset sits on top of Sync ABI Rework v13:
> 
> https://www.spinics.net/lists/dri-devel/msg105667.html
> 
> The first eight clean up and prepare sync_file for de-staging. The last four
> patches do the de-staging, moving files to drivers/dma-buf/ and include/linux/
> plus adding Documentation.
> 
> As the de-stage depends upon many changes on the staging tree it would
> be good to get all the patches merged through the staging tree if Sumit
> agrees with that.
> 
> The next step on the Sync de-stage is clean up the remaining bits 
> of the Sync Framework, mainly SW_SYNC, which is only used for testing.

Ok I looked once more at all this stuff, and there's some nitpicks I
discussed with Gustavo on irc. But really their small, and I think
perfectly ok to address them once sync_file is destaged. Especially since
there's a lot more work pending on top of this, so we really want to get
sync_file.[hc] destaged in 4.7. It'll take us a few iterations and a few
drivers using this in anger in upstream to perfect the internal interfaces
anyway, but let's get this started.

Had some real nitpicks on the docs patch, but that can also be merged
later on imo. Except for that patch, on the series:

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> 
> Thanks,
> 
> 	Gustavo
> 
> ---
> Gustavo Padovan (12):
>   staging/android: remove redundant comments on sync_merge_data
>   staging/android: drop sync_file_install() and sync_file_put()
>   staging/android: move sync_file functions comments to sync.c
>   staging/android: make sync_file_merge() static
>   staging/android: make sync_file_fdget() static
>   staging/android: prepare sync_file for de-staging
>   staging/android: improve documentation for sync_file
>   staging/android: style fix: alignment to match the open parenthesis
>   dma-buf/sync_file: de-stage sync_file headers
>   dma-buf/sync_file: de-stage sync_file
>   Documentation: include sync_file into DocBook
>   Documentation: add Sync File doc
> 
>  Documentation/DocBook/device-drivers.tmpl |   2 +
>  Documentation/dma-buf-sync_file.txt       |  65 +++++
>  drivers/Kconfig                           |   2 +
>  drivers/dma-buf/Kconfig                   |  11 +
>  drivers/dma-buf/Makefile                  |   1 +
>  drivers/dma-buf/sync_file.c               | 394 ++++++++++++++++++++++++++++++
>  drivers/staging/android/Kconfig           |   1 +
>  drivers/staging/android/sync.c            | 362 ---------------------------
>  drivers/staging/android/sync.h            |  91 +------
>  drivers/staging/android/sync_debug.c      |   5 +-
>  drivers/staging/android/uapi/sync.h       | 100 --------
>  include/linux/sync_file.h                 |  57 +++++
>  include/uapi/linux/sync_file.h            | 100 ++++++++
>  13 files changed, 638 insertions(+), 553 deletions(-)
>  create mode 100644 Documentation/dma-buf-sync_file.txt
>  create mode 100644 drivers/dma-buf/Kconfig
>  create mode 100644 drivers/dma-buf/sync_file.c
>  delete mode 100644 drivers/staging/android/uapi/sync.h
>  create mode 100644 include/linux/sync_file.h
>  create mode 100644 include/uapi/linux/sync_file.h
> 
> -- 
> 2.5.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch