linux-kernel - Re: [PATCH v3] char/rtc: replace blacklist with whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 21:52:48 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] char/rtc: replace blacklist with whitelist

On Wed, Apr 27, 2016 at 9:45 PM, Arnd Bergmann <arnd@...db.de> wrote:
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
>
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
>
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted
> or select RTC_LIB.
>
> Alpha and Loongson64 can already choose between this driver and
> an rtc-class based one. mn10300 is actually the only architecture
> now that still requires this driver, and that should be fairly
> easy to change to use rtc-cmos if we want to kill off rtc.ko
> for good.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,8 +279,7 @@ if RTC_LIB=n
>
>  config RTC
>         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> +       depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300

Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds