linux-kernel - Re: [PATCH v3] char/rtc: replace blacklist with whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 22:00:51 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] char/rtc: replace blacklist with whitelist

On Wednesday 27 April 2016 21:52:48 Geert Uytterhoeven wrote:
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -279,8 +279,7 @@ if RTC_LIB=n
> >
> >  config RTC
> >         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> > +       depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300
> 
> Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.
> 

I listed it intentionally, to make it clearer to the reader what is
going on. Actually MIPS as a dependency by itself would also be sufficient,
because that contains

	select RTC_LIB if !MACH_LOONGSON64

and RTC depends on !RTC_LIB.

	Arnd