linux-kernel - Re: [-mmots 2016-04-25] hugetlb: error: ‘cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160427080102.GA16991@gmail.com>
Date:	Wed, 27 Apr 2016 10:01:02 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Jan Beulich <jbeulich@...e.com>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 26 Apr 2016 23:14:35 +0900 Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:
> 
> > Hello,
> > 
> > v4.6-rc5-mmots-2016-04-25-17-33
> > 
> > 
> > In file included from include/linux/hugetlb.h:418:0,
> >                  from fs/hugetlbfs/inode.c:28:
> > fs/hugetlbfs/inode.c: In function 'init_hugetlbfs_fs':
> > ./arch/x86/include/asm/hugetlb.h:7:31: error: 'cpu_has_pse' undeclared (first use in this function)
> >  #define hugepages_supported() cpu_has_pse
> >                                ^
> 
> hm, how did that happen.  I had some issues with cpu_has_pse a number
> of days ago but they later went away.
> 
> In my current tree I have, in arch/x86/include/asm/hugetlb.h:
> 
> #define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE)
> 
> and that came in from linux-next.patch.  I wonder why your tree is
> different.
> 
> <looks>
> 
> OK, http://ozlabs.org/~akpm/mmots/broken-out/linux-next.patch has no
> changes to arch/x86/include/asm/hugetlb.h at all.  Maybe I fat-fingered
> something.  Odd.

So I think the reason is that cpu_has_pse is gone from the x86 devel tree, please 
use this instead:

  boot_cpu_has(X86_FEATURE_PSE)

Thanks,

	Ingo