linux-kernel - Re: [PATCH] of: Add stub for of_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5345757.9RfGSJE06M@wuerfel>
Date:	Wed, 27 Apr 2016 13:13:33 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Grant Likely <grant.likely@...aro.org>,
	Thierry Reding <treding@...dia.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Frank Rowand <frowand.list@...il.com>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] of: Add stub for of_get_next_parent()

On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> Fixes a compiler error:
> 
> drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
>     parent = of_get_next_parent(parent);
>                  ^
> 
> Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Yes, this works. I have submitted an alternative patch to fix the
build error, changing the PHY core to not use any of the OF interfaces
if CONFIG_OF is disabled.

We can also have both.

Acked-by: Arnd Bergmann <arnd@...db.de>