linux-kernel - Re: [PATCH] of: Add stub for of_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160427150039.GB4176@ulmo.ba.sec>
Date:	Wed, 27 Apr 2016 17:00:40 +0200
From:	Thierry Reding <treding@...dia.com>
To:	Arnd Bergmann <arnd@...db.de>, Rob Herring <robh+dt@...nel.org>
CC:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Grant Likely <grant.likely@...aro.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH] of: Add stub for of_get_next_parent()

On Wed, Apr 27, 2016 at 01:13:33PM +0200, Arnd Bergmann wrote:
> On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> > Fixes a compiler error:
> > 
> > drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> > drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> > ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
> >     parent = of_get_next_parent(parent);
> >                  ^
> > 
> > Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 
> Yes, this works. I have submitted an alternative patch to fix the
> build error, changing the PHY core to not use any of the OF interfaces
> if CONFIG_OF is disabled.
> 
> We can also have both.
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

I'm thinking of simply open-coding this for now, to avoid the use of
of_get_next_parent(). This is part of a set of patches that has gone
through countless revisions over the past two years and the timing
is such that adding yet another dependency will likely make it miss
the next cycle again. I'd really like to avoid that.

If nobody objects I'll volunteer to refactor this after v4.7-rc1.

Alternatively, perhaps Rob can give a very quick Acked-by on the
of_get_next_parent() addition, then I might still have time to take
this through one or two linux-next releases before sending out the
pull requests around the end of the week.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)