linux-kernel - Re: [PATCH] pinctrl: ish-pfc: avoid unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7844423-7adf-95bd-1174-9c4bddaef69b@cogentembedded.com>
Date:	Wed, 27 Apr 2016 17:13:25 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Arnd Bergmann <arnd@...db.de>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Linus Walleij <linus.walleij@...aro.org>
Cc:	Simon Horman <horms+renesas@...ge.net.au>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Ulrich Hecht <ulrich.hecht+renesas@...il.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Hisashi Nakamura <hisashi.nakamura.ak@...esas.com>,
	Takeshi Kihara <takeshi.kihara.df@...esas.com>,
	linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: ish-pfc: avoid unused variable warning

Hello.

    s/ish-/sh-/ in the subject.

On 4/27/2016 12:56 PM, Arnd Bergmann wrote:

> After the conversion to devm_pinctrl_register, we get a warning in
> sh_pfc_remove when CONFIG_PINCTRL_SH_PFC_GPIO is disabled:
>
> drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove':
> drivers/pinctrl/sh-pfc/core.c:603:17: unused variable 'pfc' [-Werror=unused-variable]
>   struct sh_pfc *pfc = platform_get_drvdata(pdev);
>
> This moves the variable definition inside of the same ifdef
> that has the only user, to get a clean build again.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 67ec8d7b4846 ("pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration")

    Ah, the broken patch also has this typo. :-)

WBR, Sergei