linux-kernel - Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427141326.GA19115@yubo-2>
Date:	Wed, 27 Apr 2016 10:13:28 -0400
From:	YU Bo <tsu.yubo@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Patard <arnaud.patard@...-net.org>,
	Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sim <nicholassimws@...il.com>, Goyal <bhumirks@...il.com>,
	Barnes <clifton.a.barnes@...il.com>,
	Sachdeva <aquannie@...il.com>, Frederick <fabf@...net.be>,
	Ravichandran <janani.rvchndrn@...il.com>, yuzibode@....com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant
 on the right side of the test warning

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote:
>On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:
>> Fixed checkpatch.pl's warning 'Comparisons should place the constant on
>> the right side of the test'
>>
>> Signed-off-by: YU Bo <tsu.yubo@...il.com>
>> ---
>>  drivers/staging/xgifb/vb_setmode.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
>> index 50c8ea4f5ab7..8bf253c224ad 100644
>> --- a/drivers/staging/xgifb/vb_setmode.c
>> +++ b/drivers/staging/xgifb/vb_setmode.c
>> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>>  		if (pVBInfo->LCDInfo & EnableScalingLCD)
>>  			tempdx &= (~PanelResInfo);
>>
>> -		if (table[i].PANELID == tempdx) {
>> +		if (tempdx == table[i].PANELID) {
>
>I don't understand why checkpatch is complaining about this one...  It
>seems like a false positive.  Maybe it's because .PANELID is a rubbish
>variable name.
Yes.I am also confused when i'm ready to submit the patch.Obviously
'temp[ad]x' is variable.My first patch have to wait a long time.:)
>
>regards,
>dan carpetner
>