linux-kernel - Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427143711.GT3217@sirena.org.uk>
Date:	Wed, 27 Apr 2016 15:37:11 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in
 regulator dts nodes

On Wed, Apr 27, 2016 at 04:31:02PM +0200, Hans de Goede wrote:
> On 27-04-16 16:24, Mark Brown wrote:

> >The regulator API should not touch any regulators that it doesn't have
> >permission to change the state for.  All other regulators are strictly
> >read only.

> How do we give permission to change state ? Is omitting the dts node,
> and thus not returning a node / constrains from regulator_of_get_init_data
> enough for the regulator API to not have permission ?

Yes, omit the DT node or mark it always on at the minute.

> Is there any way to see this in sysfs ?

Not off the top of my head, but it's in debugfs.

> >If the regulator can't be changed why is it in the DT in the first
> >place?

> The regulator is part of the pmic and the axp20x regulator driver
> registers all regulators on the pmic when the pmic-s mfd instantiated
> regulators-platform-device gets probed.

That's the driver, that's not the DT.  Drivers should always register
all the regulators in the device they're for.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)