linux-kernel - Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1fc599c-875b-8b61-23c2-de775d95201f@redhat.com>
Date:	Wed, 27 Apr 2016 16:40:05 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in
 regulator dts nodes

Hi,

On 27-04-16 16:37, Mark Brown wrote:
> On Wed, Apr 27, 2016 at 04:31:02PM +0200, Hans de Goede wrote:
>> On 27-04-16 16:24, Mark Brown wrote:
>
>>> The regulator API should not touch any regulators that it doesn't have
>>> permission to change the state for.  All other regulators are strictly
>>> read only.
>
>> How do we give permission to change state ? Is omitting the dts node,
>> and thus not returning a node / constrains from regulator_of_get_init_data
>> enough for the regulator API to not have permission ?
>
> Yes, omit the DT node or mark it always on at the minute.

Or, since regulator_of_get_init_data uses for_each_available_child_of_node
which checks the "status" value we can actually already use
"status=disabled" cool. So this simply already works :)

Regards,

Hans