linux-kernel - Re: [PATCH 20/21] X86_64, UV: Remove Obsolete GRU MMR address translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428084954.GC16679@gmail.com>
Date:	Thu, 28 Apr 2016 10:49:54 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <len.brown@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, uv4-kernel@....com,
	Dimitri Sivanich <sivanich@....com>
Subject: Re: [PATCH 20/21] X86_64, UV: Remove Obsolete GRU MMR address
 translation


* Mike Travis <travis@....com> wrote:

>  	/*
> +	 * Send a noop message in order to deliver a cross-partition interrupt
> +	 * to the SSI that contains the target message queue. Normally, the
> +	 * interrupt is automatically delivered by hardware following mesq
> +	 * operations, but some error conditions require explicit delivery.
> +	 * The noop message will trigger delivery. Otherwise partition failures
>  	 * could cause unrecovered errors.
>  	 */

This is a properly structured comment.

> +		/* Don't indicate to the app to resend the message, as it's */
> +		/* already been successfully sent.  We simply send an OK */
> +		/* (rather than fail the send with MQE_UNEXPECTED_CB_ERR), */
> +		/* assuming that the other side is receiving enough */
> +		/* interrupts to get this message processed anyway. */

This is not...

Thanks,

	Ingo