linux-kernel - Re: [PATCH 16/21] X86_64, UV: Add obtaining GAM Range Table from UV BIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428085504.GD16679@gmail.com>
Date:	Thu, 28 Apr 2016 10:55:04 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <len.brown@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, uv4-kernel@....com
Subject: Re: [PATCH 16/21] X86_64, UV: Add obtaining GAM Range Table from UV
 BIOS


* Mike Travis <travis@....com> wrote:

> +	if (uv_systab->revision >= UV_SYSTAB_VERSION_UV4) {
> +		iounmap(uv_systab);
> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);
> +		if (!uv_systab) {
> +			pr_err("UV: UVsystab: ioremap(%d) failed!\n",
> +				uv_systab->size);
> +			return;
> +		}
> +	}
> +	pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision);

So your series in general has a lot of ugly line breaks in them, which suggests 
you took checkpatch.pl output too literally. Many of the linebreaks seem 
unnecessary, such as tihs cast:.

> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);

as ioremap() returns void * so it ought to be fine to just leave out the type 
cast?

etc. Please review the rest of the series for such details as well.

Thanks,

	Ingo