linux-kernel - Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 14:52:39 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Grigori Goronzy <greg@...wn.ath.cx>
Cc:	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

On Fri, Apr 15, 2016 at 11:14:07PM +0200, Grigori Goronzy wrote:
> Use the correct types and sizes.
> 
> v2: use u8 shorthand for unsigned char.

Pleas place commit logs below the cut-off line (---).

> Signed-off-by: Grigori Goronzy <greg@...wn.ath.cx>
> ---
>  drivers/usb/serial/ch341.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index db4b561..95c8a40 100644
> --- a/drivers/usb/serial/ch341.c
> +++ b/drivers/usb/serial/ch341.c
> @@ -115,7 +115,7 @@ static int ch341_control_out(struct usb_device *dev, u8 request,
>  
>  static int ch341_control_in(struct usb_device *dev,
>  			    u8 request, u16 value, u16 index,
> -			    char *buf, unsigned bufsize)
> +			    u8 *buf, unsigned bufsize)

Just use void * for the buffer parameter.

>  {
>  	int r;
>  
> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device *dev, u8 control)
>  
>  static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv)
>  {
> -	char *buffer;
> +	unsigned char *buffer;
>  	int r;
> -	const unsigned size = 8;
> +	const unsigned size = 2;

Did you reply to Oliver's comment about this change? Are you sure this
won't break some old device expecting to be asked for eight bytes even
if only two are returned?

I suggest breaking this out into a separate patch either way.

Thanks,
Johan