linux-kernel - Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 16:19:31 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	"J.D. Schroeder" <Linux.HWI@...min.com>,
	<linux-kernel@...r.kernel.org>, <lgirdwood@...il.com>,
	<broonie@...nel.org>, <perex@...ex.cz>, <tiwai@...e.com>,
	<jsarha@...com>, <alsa-devel@...a-project.org>
CC:	Jim Lodes <jim.lodes@...min.com>,
	"J.D. Schroeder" <jay.schroeder@...min.com>
Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx

On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@...min.com>
> 
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> 
> Signed-off-by: Jim Lodes <jim.lodes@...min.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@...min.com>
> ---
>  sound/soc/davinci/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>  
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> -			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> +			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
>  		mcasp->bclk_master = 0;
>  		break;
>  	default:
> 


-- 
Péter