linux-kernel - Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGm1_ksHa_148RzRHF-=qnTJY1ffE=apTW3kpabr=TyQpKCYZw@mail.gmail.com>
Date:	Fri, 29 Apr 2016 15:21:37 +0200
From:	Yegor Yefremov <yegorslists@...glemail.com>
To:	Richard Genoud <richard.genoud@...il.com>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios

On Fri, Apr 29, 2016 at 3:11 PM, Richard Genoud
<richard.genoud@...il.com> wrote:
> 2016-04-29 13:40 GMT+02:00 Geert Uytterhoeven <geert+renesas@...der.be>:
>> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
>> It doesn't make much sense to emulate GPIOs using other GPIOs, hence
>> drop support for that.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>> Reviewed-by: Peter Hurley <peter@...leysoftware.com>
>> ---
>> v2:
>>   - Add Reviewed-by,
>>   - Drop forgotten UART_GPIO_OUT[12] enum values.
>> ---
>>  drivers/tty/serial/serial_mctrl_gpio.c | 2 --
>>  drivers/tty/serial/serial_mctrl_gpio.h | 2 --
>>  2 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 02147361eaa94747..821ffa637eb630cb 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -43,8 +43,6 @@ static const struct {
>>         { "rng", TIOCM_RNG, false, },
>>         { "rts", TIOCM_RTS, true, },
>>         { "dtr", TIOCM_DTR, true, },
>> -       { "out1", TIOCM_OUT1, true, },
>> -       { "out2", TIOCM_OUT2, true, },
>>  };
>>
>>  void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
>> index bcfad5d1db61decf..332a33ab0647cbe3 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.h
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.h
>> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
>>         UART_GPIO_RI = UART_GPIO_RNG,
>>         UART_GPIO_RTS,
>>         UART_GPIO_DTR,
>> -       UART_GPIO_OUT1,
>> -       UART_GPIO_OUT2,
>>         UART_GPIO_MAX,
>>  };
>>
>> --
>> 1.9.1
>>
> It seems all right now !
>
>
> Reviewed-by: Richard Genoud <richard.genoud@...il.com>

Reviewed-by: Yegor Yefremov <yegorslists@...glemail.com>