linux-kernel - Re: [PATCH] scripts/dtc: dt_to_config - report kernel config options for a devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <572383A4.2030808@gmail.com>
Date:	Fri, 29 Apr 2016 08:54:12 -0700
From:	Frank Rowand <frowand.list@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Gaurav Minocha <gaurav.minocha.os@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] scripts/dtc: dt_to_config - report kernel config options
 for a devicetree

On 4/28/2016 11:44 PM, Geert Uytterhoeven wrote:
> On Fri, Apr 29, 2016 at 8:39 AM, Gaurav Minocha
> <gaurav.minocha.os@...il.com> wrote:
>> On Thu, Apr 28, 2016 at 3:32 PM, Rob Herring <robh+dt@...nel.org> wrote:
>>> On Thu, Apr 28, 2016 at 4:46 PM, Frank Rowand <frowand.list@...il.com> wrote:
>>>> From: Frank Rowand <frank.rowand@...sony.com>
>>>>
>>>> Determining which kernel config options need to be enabled for a
>>>> given devicetree can be a painful process.  Create a new tool to
>>>> find the drivers that may match a devicetree node compatible,
>>>> find the kernel config options that enable the driver, and
>>>> optionally report whether the kernel config option is enabled.
>>>
>>> I would find this more useful to output a config fragment with all the
>>> options enabled. The hard part there is enabling the options a given
>>> option is dependent on which I don't think kbuild takes care of.
>>
>> Do you mean to generate something like .config? If yes, then IMO it would
>> not be a correct configuration file.
> 
> A fragment to be appended to your current .config.
> 
> After that, an additional run of "make oldconfig" should (hopefully) bring
> everything into good shape.

$ scripts/dtc/dt_to_config                          \
     --config=$KBUILD_OUTPUT/.config                \
     arch/arm/boot/dts/qcom-apq8074-dragonboard.dts \
     | grep "^............F"                        \
     | cut -d ":" -f5                               \
     | sed -e 's| $|=y|'                            \
     | sed -e 's| ||g'
CONFIG_ARCH_U300=y
CONFIG_SOC_IMX27=y
CONFIG_SOC_IMX31=y
CONFIG_ARCH_U300=y
CONFIG_SOC_IMX27=y
CONFIG_SOC_IMX31=y
CONFIG_ARM_BIG_LITTLE_CPUIDLE=y
CONFIG_QCOM_SMP2P=y
CONFIG_QCOM_SMP2P=y
CONFIG_QCOM_SMSM=y
CONFIG_QCOM_SPMI_TEMP_ALARM=y
CONFIG_QCOM_SPMI_IADC=y
CONFIG_INPUT_PM8941_PWRKEY=y
CONFIG_QCOM_SPMI_TEMP_ALARM=y
CONFIG_QCOM_SPMI_VADC=y
CONFIG_BACKLIGHT_PM8941_WLED=y


But Gaurav is correct.  The answer is not this easy.  For example, there
may be multiple drivers that match a compatible value.  But only one of
those drivers will be the correct one.  That is just one example, some
cases become are much more complex.

I started writing code to try to score how good each compatible match is
so the best match could be picked.  At the moment, it is 255 lines and
not very functional.  I may continue experimenting with scoring in the
future.

-Frank