linux-kernel - Re: [PATCH] crypto: constify ccp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 May 2016 08:58:34 -0500
From:	Gary R Hook <ghook@....com>
To:	Julia Lawall <Julia.Lawall@...6.fr>, <linux-crypto@...r.kernel.org>
CC:	Tom Lendacky <thomas.lendacky@....com>,
	<kernel-janitors@...r.kernel.org>, Gary Hook <gary.hook@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: constify ccp_actions structure

On 05/01/2016 06:52 AM, Julia Lawall wrote:
> The ccp_actions structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Gary Hook <gary.hook@....com>

> ---
>   drivers/crypto/ccp/ccp-dev-v3.c |    2 +-
>   drivers/crypto/ccp/ccp-dev.h    |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c
> index 597fc50..d7a7103 100644
> --- a/drivers/crypto/ccp/ccp-dev-v3.c
> +++ b/drivers/crypto/ccp/ccp-dev-v3.c
> @@ -526,7 +526,7 @@ static irqreturn_t ccp_irq_handler(int irq, void *data)
>   	return IRQ_HANDLED;
>   }
>   
> -static struct ccp_actions ccp3_actions = {
> +static const struct ccp_actions ccp3_actions = {
>   	.perform_aes = ccp_perform_aes,
>   	.perform_xts_aes = ccp_perform_xts_aes,
>   	.perform_sha = ccp_perform_sha,
> diff --git a/drivers/crypto/ccp/ccp-dev.h b/drivers/crypto/ccp/ccp-dev.h
> index 5d986c9..bd41ffce 100644
> --- a/drivers/crypto/ccp/ccp-dev.h
> +++ b/drivers/crypto/ccp/ccp-dev.h
> @@ -162,7 +162,7 @@ struct ccp_actions {
>   /* Structure to hold CCP version-specific values */
>   struct ccp_vdata {
>   	unsigned int version;
> -	struct ccp_actions *perform;
> +	const struct ccp_actions *perform;
>   };
>   
>   extern struct ccp_vdata ccpv3;
>