linux-kernel - Re: [PATCH] of: include errno.h in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 May 2016 09:00:32 -0500
From:	Rob Herring <robh@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, Dave Airlie <airlied@...hat.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] of: include errno.h in of_graph.h

On Mon, May 02, 2016 at 12:59:19PM +0200, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we have to include linux/errno.h before
> including of_graph.h, or get build errors like in the newly added
> sun4i drm driver:
> 
> In file included from ../drivers/gpu/drm/sun4i/sun4i_drv.c:14:0:
> include/linux/of_graph.h: In function 'of_graph_parse_endpoint':
> include/linux/of_graph.h:58:10: error: 'ENOSYS' undeclared (first use in this function)
> 
> A better solution is to ensure that the header can be included
> by itself, so let's include linux/errno.h here to fix the error
> we just got, and any similar future error.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> ---
>  include/linux/of_graph.h | 1 +
>  1 file changed, 1 insertion(+)

Applied.

Rob