linux-kernel - Re: [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160502193305.GI24851@localhost>
Date:	Mon, 2 May 2016 14:33:05 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:	linux-pci@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver

On Sun, May 01, 2016 at 02:08:31PM +0900, Yoshinori Sato wrote:

> +static __init int sh7751_pci_probe(struct platform_device *pdev)
> +{
> ...

> +	pci->cfg.ops = &pci_sh7751_ops;
> +	return pci_host_common_probe(pdev, pci);
> +}
> +
> +static __refdata struct platform_driver sh7751_pci_driver = {
> +	.driver = {
> +		.name = "sh7751-pci",
> +		.of_match_table = sh7751_pci_of_match,
> +	},
> +	.probe = sh7751_pci_probe,
> +};
> +module_platform_driver(sh7751_pci_driver);

I *think* that if you use builtin_platform_driver_probe() or
module_platform_driver_probe() here, you can get rid of the __refdata
on sh7751_pci_driver while keeping sh7751_pci_probe() as __init.