linux-kernel - Re: [PATCH] rtc: rv3029: hide unused i2c device table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 May 2016 12:08:50 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Michael Buesch <m@...s.ch>,
	Mylene JOSSERAND <mylene.josserand@...e-electrons.com>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: rv3029: hide unused i2c device table

On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote :
> The added support for SPI mode made it possible to configure the driver
> when I2C is disabled, leaving an unused device table:
> 
> drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable]
> 
> This moves the table inside of the #ifdef section that has the
> only user, to avoid the harmless warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049")
> ---
>  drivers/rtc/rtc-rv3029c2.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com