linux-kernel - Re: [tip:x86/boot] x86/boot: Clean up pointer casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160506104438.GF24044@pd.tnic>
Date:	Fri, 6 May 2016 12:44:38 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Kees Cook <keescook@...omium.org>, torvalds@...ux-foundation.org,
	hpa@...or.com, dyoung@...hat.com, tglx@...utronix.de,
	luto@...nel.org, peterz@...radead.org, dvlasenk@...hat.com,
	linux-kernel@...r.kernel.org, brgerst@...il.com,
	luto@...capital.net, akpm@...ux-foundation.org, bhe@...hat.com,
	yinghai@...nel.org, vgoyal@...hat.com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/boot] x86/boot: Clean up pointer casting

On Fri, May 06, 2016 at 12:36:19PM +0200, Ingo Molnar wrote:
> 
> Hm, your patch throws a lot of warnings during allnoconfig builds:
> 
> In file included from arch/x86/boot/compressed/error.c:6:0:
> arch/x86/boot/compressed/misc.h: In function ‘choose_random_location’:
> arch/x86/boot/compressed/misc.h:83:9: warning: return makes pointer from integer 
> without a cast [-Wint-conversion]
>   return output_ptr;
>          ^

Blergh, that's when choose_random_location() is a stub and it needs to
do

	return (unsigned char *)output_ptr;

too.

Lemme run all the *config builds on the fixed version before I send you
a v2.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.