linux-kernel - Re: Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 May 2016 08:31:34 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Guenter Roeck <guenter@...ck-us.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84

On Thu, May 5, 2016 at 11:12 PM, Guenter Roeck <guenter@...ck-us.net> wrote:
> alpha:allmodconfig fails to build with the following error.
>
> drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
> drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared
>
> Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap
> reservation sizing").
>
> HPAGE_SIZE is not defined for all architectures and was up to now not used
> in driver code. All other architectures with 64 bit physical address provide
> the
> definition, though, as far as I can see, so it may be that only alpha is
> affected.
>
> Since stable is copied - this will also result in stable build errors
> if applied to -stable branches.

Ah, sorry, I had only built alpha_defconfig before pushing that one.
I'll send a follow on fix, thanks for the report.