linux-kernel - Re: [PATCHv2 net] bridge: fix igmp / mld query parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160506.125642.581240999988344349.davem@davemloft.net>
Date:	Fri, 06 May 2016 12:56:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@...3.blue
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	sw@...onwunderlich.de
Subject: Re: [PATCHv2 net] bridge: fix igmp / mld query parsing

From: Linus Lüssing <linus.luessing@...3.blue>
Date: Wed,  4 May 2016 17:25:02 +0200

> With the newly introduced helper functions the skb pulling is hidden
> in the checksumming function - and undone before returning to the
> caller.
> 
> The IGMP and MLD query parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header.
> 
> If there is a querier somewhere else, then this either causes
> the multicast snooping to stay disabled even though it could be
> enabled. Or, if we have the querier enabled too, then this can
> create unnecessary IGMP / MLD query messages on the link.
> 
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
> 
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Simon Wunderlich <sw@...onwunderlich.de>
> Signed-off-by: Linus Lüssing <linus.luessing@...3.blue>

Applied and queued up for -stable, thanks.