linux-kernel - Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1462748483.9308.1.camel@decadent.org.uk>
Date:	Mon, 09 May 2016 00:01:23 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	fugang.duan@....com, davem@...emloft.net, kan.liang@...el.com,
	decot@...glers.com, aduyck@...antis.com, jiri@...lanox.com,
	jacob.e.keller@...el.com, tom@...bertland.com, andrew@...n.ch,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct
 net_device

On Mon, 2016-05-09 at 00:47 +0200, Philippe Reynes wrote:
> On 09/05/16 00:22, Ben Hutchings wrote:
> > 
> > On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote:
> > > 
> > > The private structure contain a pointer to phydev, but the structure
> > > net_device already contain such pointer. So we can remove the pointer
> > > phydev in the private structure, and update the driver to use the one
> > > contained in struct net_device.
> > But there is no central code that updates the pointer, so:
> The function phy_attach_direct and phy_detach update the pointer
> phydev in the struct net_device.
[...]
> So from my understanding, those two lines aren't usefull.
> May you confirm that I'm on the right way please ?

Sorry, you're right.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)