linux-kernel - Re: [PATCH] md: make the code more readable in the for-loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160508230317.GB8100@kernel.org>
Date:	Sun, 8 May 2016 16:03:17 -0700
From:	Shaohua Li <shli@...nel.org>
To:	Tiezhu Yang <kernelpatch@....com>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md: make the code more readable in the for-loop

On Sun, May 08, 2016 at 08:56:55PM +0800, Tiezhu Yang wrote:
> This patch modifies raid1.c, raid10.c and raid5.c
> to make the code more readable in the for-loop
> and also fixes the scripts/checkpatch.pl error:
> ERROR: trailing statements should be on next line.
> 
> Signed-off-by: Tiezhu Yang <kernelpatch@....com>
> @@ -3573,7 +3573,8 @@ static void handle_stripe_dirtying(struct r5conf *conf,
>  		pr_debug("force RCW rmw_level=%u, recovery_cp=%llu sh->sector=%llu\n",
>  			 conf->rmw_level, (unsigned long long)recovery_cp,
>  			 (unsigned long long)sh->sector);
> -	} else for (i = disks; i--; ) {
> +	} else
> +	for (i = disks - 1; i >= 0; i--) {
>  		/* would I have to read this buffer for read_modify_write */
>  		struct r5dev *dev = &sh->dev[i];
>  		if ((dev->towrite || i == sh->pd_idx || i == sh->qd_idx) &&

Applied. I move the for statement to be in a {} of else statement.