linux-kernel - Re: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1605090923460.27332@macbook-air>
Date:	Mon, 9 May 2016 09:54:30 -0400 (EDT)
From:	Vince Weaver <vincent.weaver@...ne.edu>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
cc:	linux-perf-users@...r.kernel.org, peterz@...radead.org,
	acme@...hat.com, linux-snps-arc@...ts.infradead.org,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	vincent.weaver@...ne.edu
Subject: Re: [RFC 2/2] perf/core: change errno for sampling event not supported
 in hardware

On Mon, 9 May 2016, Vineet Gupta wrote:

> This allows userspace to identify this case specifically from the
> catch all error msg it prints currently.
> 
> This is an ABI change

An ABI change which will probably break things.

The original change from ENODEV to ENOTSUPP managed to break things 
although it took four kernel releases before anyone noticed.

The usage of ENOTSUPP was my fault, though I feel like at the time I was 
told that ENOTSUPP is for internal kernel usage and would be converted to 
EOPNOTSUPP when returning an error to userspace.  But now I 
can't find any sort of reference for that at all, except the fact that

	/usr/include/x86_64-linux-gnu/bits/errno.h

has
	/* Linux has no ENOTSUP error code.  */
	# define ENOTSUP EOPNOTSUPP

in it... but wait, that's ENOTSUP not ENOTSUPP.  Blargh.

Vince