linux-kernel - Re: [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1462878590.3050.5.camel@pengutronix.de>
Date:	Tue, 10 May 2016 13:09:50 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Jiancheng Xue <xuejiancheng@...ilicon.com>
Cc:	mturquette@...libre.com, sboyd@...eaurora.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	yanhaifeng@...ilicon.com, haojian.zhuang@...aro.org,
	zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
	yanghongwei@...ilicon.com
Subject: Re: [PATCH 1/5] reset: hisilicon: change the definition of
 hisi_reset_init

Hi Jiancheng,

Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
> Change the input arguments type to struct platform_device pointer.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@...ilicon.com>
[...]
> diff --git a/drivers/clk/hisilicon/reset.h b/drivers/clk/hisilicon/reset.h
> index 677d773..9a69374 100644
> --- a/drivers/clk/hisilicon/reset.h
> +++ b/drivers/clk/hisilicon/reset.h
> @@ -22,10 +22,11 @@ struct device_node;
>  struct hisi_reset_controller;
>  
>  #ifdef CONFIG_RESET_CONTROLLER
> -struct hisi_reset_controller *hisi_reset_init(struct device_node *np);
> +struct hisi_reset_controller *hisi_reset_init(struct platform_device *pdev);

Changing this without changing the call to hisi_reset_init() in 
hi3519_clk_probe at the same time will break compilation until
patch 5 is applied.

regards
Philipp