linux-kernel - Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1462878595.3050.6.camel@pengutronix.de>
Date:	Tue, 10 May 2016 13:09:55 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Jiancheng Xue <xuejiancheng@...ilicon.com>
Cc:	mturquette@...libre.com, sboyd@...eaurora.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	yanhaifeng@...ilicon.com, haojian.zhuang@...aro.org,
	zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
	yanghongwei@...ilicon.com
Subject: Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and
 fix some issues

Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
> 1. Add driver remove path.
> 2. Fix some issues.
>    -Fix the ordering issue about clock provider being published.
>    -Add error checking upon registering clocks.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@...ilicon.com>
> ---
>  drivers/clk/hisilicon/clk-hi3519.c | 116 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 100 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
> index 715c730..51b173e 100644
> --- a/drivers/clk/hisilicon/clk-hi3519.c
> +++ b/drivers/clk/hisilicon/clk-hi3519.c
[...]
> -	rstc = hisi_reset_init(np);
> -	if (!rstc)
[...]
> +	crg->rstc = hisi_reset_init(pdev);
> +	if (!crg->rstc)
[...]

The hisi_reset_init(np) -> hisi_reset_init(pdev) change should be part
of patch 1.

regards
Philipp