linux-kernel - Re: [PATCH 5/9] ASoC: es8328: Use more suitable definition for mic bias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510175335.GC6261@sirena.org.uk>
Date:	Tue, 10 May 2016 18:53:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	John Keeping <john@...anate.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 5/9] ASoC: es8328: Use more suitable definition for mic
 bias

On Mon, May 09, 2016 at 12:24:33PM +0100, John Keeping wrote:

> -	SND_SOC_DAPM_SUPPLY("Mic Bias", ES8328_ADCPOWER,
> -			ES8328_ADCPOWER_MIC_BIAS_OFF, 1, NULL, 0),
> +	SND_SOC_DAPM_MICBIAS("Mic Bias", ES8328_ADCPOWER,
> +			ES8328_ADCPOWER_MIC_BIAS_OFF, 1),

No, this is broken.  The specialist MICBIAS widget is legacy and should
not be used.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)