lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 May 2016 10:38:36 +0100 From: Julien Grall <julien.grall@....com> To: Mark Rutland <mark.rutland@....com> Cc: linux-arm-kernel@...ts.infradead.org, will.deacon@....com, linux-kernel@...r.kernel.org, catalin.marinas@....com, stable@...r.kernel.org, "Suzuki K. Poulose" <suzuki.poulose@....com> Subject: Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str Hi Mark, On 10/05/2016 15:54, Mark Rutland wrote: > On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote: >> The loop that browses the array compat_hwcap_str will stop when a NULL >> is encountered, however NULL is missing at the end of array. This will >> result to overrun until one NULL is found somewhere in the memory. > > Probably worth adding something like: > > Note for backporting: commit 12d11817eaafa414 ("arm64: Move > /proc/cpuinfo handling code") moved this code. Prior to that commit, the > same change should be made in arch/arm64/kernel/setup.c. I can resend the patch with this changes. > >> Fixes: 44b82b7700d0 "arm64: Fix up /proc/cpuinfo" >> Signed-off-by: Julien Grall <julien.grall@....com> >> Cc: stable@...r.kernel.org >> >> --- >> >> Cc: Mark Rutland <mark.rutland@....com> >> Cc: Suzuki K. Poulose <suzuki.poulose@....com> >> --- > > Wierd middle '---' between the Cc lines above. It is an habit I have with Xen-devel as the Cc are not necessary after it has been committed. > > Otherwise: > > Reviewed-by: Mark Rutland <mark.rutland@....com> Thank you! Regards, -- Julien Grall
Powered by blists - more mailing lists