linux-kernel - Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511151615.GA13006@gmail.com>
Date:	Wed, 11 May 2016 17:16:15 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Dave Hansen <dave.hansen@...ux.intel.com>
Cc:	Yu-cheng Yu <yu-cheng.yu@...el.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...e.de>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
	"Ravi V. Shankar" <ravi.v.shankar@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES


* Dave Hansen <dave.hansen@...ux.intel.com> wrote:

> On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> > XSAVES uses compacted format and is a kernel instruction. The kernel
> > should use standard-format, non-supervisor state data for PTRACE.
> > 
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@...el.com>
> 
> This looks fine.  There are a few comments that could use some sprucing
> up, like:
> 
> +	/*
> +	 * Reject if the user sets any forbidden features.
> +	 */
> 
> But it's minor stuff.
> 
> Reviewed-by: Dave Hansen <dave.hansen@...el.com>

Well it's too late for v4.7 due to intrusiveness, so please refine the series and 
also incorporate the cleanups requested by Boris. I can put it into -tip whenever 
you guys submit it, but it will have to wait for v4.8 most likely.

Thanks,

	Ingo