[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8737povd4n.fsf@intel.com>
Date: Wed, 11 May 2016 17:16:24 +0200
From: jeremy.compostella@...el.com (Compostella, Jeremy)
To: Matt Fleming <matt@...eblueprint.co.uk>
Cc: "Elliott\, Robert \(Persistent Memory\)" <elliott@....com>,
Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
"H . Peter Anvin" <hpa@...or.com>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-efi\@vger.kernel.org" <linux-efi@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 2/5] efibc: Fix excessive stack footprint warning
You're right. Here is the new patch.
Thanks,
Jérémy
View attachment "0001-efibc-report-more-information-in-the-error-messages.patch" of type "text/x-diff" (1401 bytes)
Matt Fleming <matt@...eblueprint.co.uk> writes:
> On Tue, 10 May, at 10:40:22AM, Jeremy Compostella wrote:
>> Why not. See patch as attachment.
>>
>> Thanks,
>>
>> Jérémy
>>
>
>> From 8a9b07e2d7242fa8a36157f1025202a96c3c7c9a Mon Sep 17 00:00:00 2001
>> From: Jeremy Compostella <jeremy.compostella@...el.com>
>> Date: Tue, 10 May 2016 10:34:21 +0200
>> Subject: [PATCH] efibc: report the EFI variable name in the error messages
>>
>> Report the name of the EFI variable if the value is incorrect or if
>> efibc_set_variable() fails to allocate the struct efivar_entry object.
>>
>> Signed-off-by: Jeremy Compostella <jeremy.compostella@...el.com>
>> ---
>> drivers/firmware/efi/efibc.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c
>> index cb4f573..93d34a1 100644
>> --- a/drivers/firmware/efi/efibc.c
>> +++ b/drivers/firmware/efi/efibc.c
>> @@ -37,13 +37,14 @@ static int efibc_set_variable(const char *name, const char *value)
>> size_t size = (strlen(value) + 1) * sizeof(efi_char16_t);
>>
>> if (size > sizeof(entry->var.Data)) {
>> - pr_err("value is too large");
>> + pr_err("value is too large for %s EFI variable", name);
>> return -EINVAL;
>> }
>
> It'd be a good idea to print 'size' too.
>
>>
>> entry = kmalloc(sizeof(*entry), GFP_KERNEL);
>> if (!entry) {
>> - pr_err("failed to allocate efivar entry");
>> + pr_err("failed to allocate efivar entry for %s EFI variable",
>> + name);
>> return -ENOMEM;
>> }
>
> Aren't these pr_err() calls missing newline characters?
--
One Emacs to rule them all
Powered by blists - more mailing lists