linux-kernel - Re: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511193627.GH3190@twins.programming.kicks-ass.net>
Date:	Wed, 11 May 2016 21:36:27 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vineet Gupta <vgupta@...opsys.com>
Cc:	Vince Weaver <vincent.weaver@...ne.edu>,
	linux-perf-users@...r.kernel.org, acme@...hat.com,
	linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
	mingo@...nel.org
Subject: Re: [RFC 2/2] perf/core: change errno for sampling event not
 supported in hardware

On Mon, May 09, 2016 at 10:53:43PM +0530, Vineet Gupta wrote:

> Right thats what I feared. But hold on, I don't think we need to change the ABI to
> achieve what we want. Gosh why did I even take that path.
> 
> Currently the errno switch case in perf_evsel__open_strerror() in doesn't handle
> ENOTSUPP. So how about we add that - augmented with the same sample_period !0
> check to barf for lack of sampling support.
> 
> Do you see anything wrong with that ?

Should work I think.