linux-kernel - [PATCH 1/3] usb: pci: Remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <149f6b90932682cd4c04af6e6e505d65010ad0a6.1462967567.git.bankarsandhya512@gmail.com>
Date:	Wed, 11 May 2016 18:08:15 +0530
From:	Sandhya Bankar <bankarsandhya512@...il.com>
To:	gregkh@...uxfoundation.org, johnyoun@...opsys.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the
device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@...il.com>
---
 drivers/usb/dwc2/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index ae41961..c76fade 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -69,7 +69,6 @@ static void dwc2_pci_remove(struct pci_dev *pci)
 	platform_device_unregister(glue->dwc2);
 	usb_phy_generic_unregister(glue->phy);
 	kfree(glue);
-	pci_set_drvdata(pci, NULL);
 }
 
 static int dwc2_pci_probe(struct pci_dev *pci,
-- 
1.8.3.4