linux-kernel - Re: [PATCH v7 00/13] x86/xsaves: Fix XSAVES issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160511203404.GR2180@pd.tnic>
Date:	Wed, 11 May 2016 22:34:04 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Dave Hansen <dave.hansen@...ux.intel.com>
Cc:	Yu-cheng Yu <yu-cheng.yu@...el.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Andy Lutomirski <luto@...nel.org>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
	"Ravi V. Shankar" <ravi.v.shankar@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH v7 00/13] x86/xsaves: Fix XSAVES issues

On Wed, May 11, 2016 at 01:14:03PM -0700, Dave Hansen wrote:
> But, seriously, he's churning through, responding to feedback and
> improving the patches quickly.  I only wish most patch authors did this.
>  And, despite breaking it up into 13 pieces, there is *NOT* a lot of
> code here.

I don't think we review only code, do we?! And as I pointed out a couple
of times, those patches weren't clean. Hell, they even didn't build on
tip/master. So even the "responding to feedback" failed. So what is your
point again?

> There's no sane reason to wait a week between iterations.

I don't think so - review is review and takes time. You should know this
even better than me.

> Just speak up if you want off the cc.

Sure. I thought you'd never ask.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--