lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 16 May 2016 11:02:38 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Staging: comedi:Fix checkpatch issue in s626.c

On 12/05/16 07:59, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>
> ---
>   drivers/staging/comedi/drivers/s626.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 43ab2e4..13f302d 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -718,7 +718,7 @@ static uint16_t s626_get_mode_a(struct comedi_device *dev,
>   	uint16_t cra;
>   	uint16_t crb;
>   	uint16_t setup;
> -	unsigned cntsrc, clkmult, clkpol, encmode;
> +	unsigned int cntsrc, clkmult, clkpol, encmode;
>
>   	/* Fetch CRA and CRB register images. */
>   	cra = s626_debi_read(dev, S626_LP_CRA(chan));
> @@ -773,7 +773,7 @@ static uint16_t s626_get_mode_b(struct comedi_device *dev,
>   	uint16_t cra;
>   	uint16_t crb;
>   	uint16_t setup;
> -	unsigned cntsrc, clkmult, clkpol, encmode;
> +	unsigned int cntsrc, clkmult, clkpol, encmode;
>
>   	/* Fetch CRA and CRB register images. */
>   	cra = s626_debi_read(dev, S626_LP_CRA(chan));
> @@ -848,7 +848,7 @@ static void s626_set_mode_a(struct comedi_device *dev,
>   	struct s626_private *devpriv = dev->private;
>   	uint16_t cra;
>   	uint16_t crb;
> -	unsigned cntsrc, clkmult, clkpol;
> +	unsigned int cntsrc, clkmult, clkpol;
>
>   	/* Initialize CRA and CRB images. */
>   	/* Preload trigger is passed through. */
> @@ -926,7 +926,7 @@ static void s626_set_mode_b(struct comedi_device *dev,
>   	struct s626_private *devpriv = dev->private;
>   	uint16_t cra;
>   	uint16_t crb;
> -	unsigned cntsrc, clkmult, clkpol;
> +	unsigned int cntsrc, clkmult, clkpol;
>
>   	/* Initialize CRA and CRB images. */
>   	/* IndexSrc is passed through. */
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Powered by blists - more mailing lists