linux-kernel - Re: [PATCH 3/4] Staging: comedi: fix type issue in s626.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57399BF7.50105@mev.co.uk>
Date:	Mon, 16 May 2016 11:07:51 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Staging: comedi: fix type issue in s626.c

On 12/05/16 07:59, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a type issues
> found by the checkpatch.pl tool.
>
> i.e Prefer kernel type 'u8' over 'uint8_t'
>      Prefer kernel type 'u16' over 'uint16_t'
>      Prefer kernel type 'u32' over 'uint32_t'
>      Prefer kernel type 's16' over 'int16_t'
>      Prefer kernel type 's32' over 'int32_t'
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>
> ---
>   drivers/staging/comedi/drivers/s626.c | 150 +++++++++++++++++-----------------
>   1 file changed, 75 insertions(+), 75 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 13f302d..fb27089 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -75,7 +75,7 @@ struct s626_buffer_dma {
>   };
>
>   struct s626_private {
> -	uint8_t ai_cmd_running;		/* ai_cmd is running */
> +	u8 ai_cmd_running;		/* ai_cmd is running */
>   	unsigned int ai_sample_timer;	/* time between samples in
>   					 * units of the timer
>   					 */
> @@ -83,22 +83,22 @@ struct s626_private {
>   	unsigned int ai_convert_timer;	/* time between conversion in
>   					 * units of the timer
>   					 */
> -	uint16_t counter_int_enabs;	/* counter interrupt enable mask
> +	u16 counter_int_enabs;		/* counter interrupt enable mask
>   					 * for MISC2 register
>   					 */
> -	uint8_t adc_items;		/* number of items in ADC poll list */
> +	u8 adc_items;		/* number of items in ADC poll list */
>   	struct s626_buffer_dma rps_buf;	/* DMA buffer used to hold ADC (RPS1)
>   					 * program
>   					 */
>   	struct s626_buffer_dma ana_buf;	/* DMA buffer used to receive ADC data
>   					 * and hold DAC data
>   					 */
> -	uint32_t *dac_wbuf;		/* pointer to logical adrs of DMA buffer
> +	u32 *dac_wbuf;		/* pointer to logical adrs of DMA buffer
>   					 * used to hold DAC data
>   					 */
> -	uint16_t dacpol;		/* image of DAC polarity register */
> -	uint8_t trim_setpoint[12];	/* images of TrimDAC setpoints */
> -	uint32_t i2c_adrs;		/* I2C device address for onboard EEPROM
> +	u16 dacpol;		/* image of DAC polarity register */
> +	u8 trim_setpoint[12];	/* images of TrimDAC setpoints */
> +	u32 i2c_adrs;		/* I2C device address for onboard EEPROM
>   					 * (board rev dependent)
>   					 */
>   };

The patch is reasonable, but messes up the alignment of those comments, 
especially the multi-line comments.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-