linux-kernel - Re: [PATCH] ideapad-laptop: add a new WMI string for ESC key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160516233816.GB3402@f23x64.localdomain>
Date:	Mon, 16 May 2016 16:38:16 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Denis Gordienko <denis.gordienko.mail@...il.com>
Cc:	Christian Hesse <mail@...rm.de>,
	Philippe Coval <philippe.coval@...n.eurogiciel.org>,
	Ike Panhc <ike.pan@...onical.com>,
	linux-kernel@...r.kernel.org,
	Dmitry Tunin <hanipouspilot@...il.com>,
	platform-driver-x86@...r.kernel.org,
	John Dahlstrom <jodarom@....org>,
	Hans de Goede <hdegoede@...hat.com>,
	Arnd Bergmann <arnd@...db.de>,
	Josh Boyer <jwboyer@...oraproject.org>
Subject: Re: [PATCH] ideapad-laptop: add a new WMI string for ESC key

On Thu, May 12, 2016 at 12:34:05AM +0300, Denis Gordienko wrote:
> Hi, Darren. This patch already tested on my laptop and I can confirm - it's
> work fine.

Awesome, thanks! Added your tested-by.

> Denis
> 11 Май 2016 г. 23:09 пользователь "Darren Hart" <dvhart@...radead.org>
> написал:
> 
> On Mon, May 09, 2016 at 11:49:21PM +0200, Arnd Bergmann wrote:
> > My patch to the ideapad-laptop driver to get the ESC key working on the
> > Yoga 1170 (Yoga 3) failed to do the same for the following model, the
> > Lenovo Yoga 700.
> >
> > Denis Gordienko managed to get it working by adding another GUID for the
> > new WMI interface. I have adapted his patch to normal coding style
> > and simplified it a bit for inclusion, but this patch is currently
> > untested.
> >
> > Link:
> https://forums.lenovo.com/t5/Lenovo-Yoga-Series-Notebooks/YOGA-3-14-How-to-reclaim-my-Esc-key-and-permanently-disable/m-p/3317499
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Cc: Denis Gordienko <denis.gordienko.mail@...il.com>
> 
> Looks good to me, but of course I would like to see some testing. Denis, I
> presume you have a Yoga 700 you could verify this version of your patch on?
> Would you be willing to do so?
> 
> 
> > ---
> >  drivers/platform/x86/ideapad-laptop.c | 19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> > index 1d49db124753..531ecca9dbe3 100644
> > --- a/drivers/platform/x86/ideapad-laptop.c
> > +++ b/drivers/platform/x86/ideapad-laptop.c
> > @@ -48,7 +48,10 @@
> >  #define CFG_CAMERA_BIT       (19)
> >
> >  #if IS_ENABLED(CONFIG_ACPI_WMI)
> > -static const char ideapad_wmi_fnesc_event[] =
> "26CAB2E5-5CF1-46AE-AAC3-4A12B6BA50E6";
> > +static const char* ideapad_wmi_fnesc_events[] = {

Arnd, should this be:

static const char *const ideapad_wmi_fnesc_events[] = {

?

Checkpatch complains, I see both usages throughout the kernel. I believe we do
want a const array of const char arrays, so I think this is a better
declaration.

Any objection to this change?

-- 
Darren Hart
Intel Open Source Technology Center