linux-kernel - RE: [PATCH] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 08:37:43 +0000
From:	Dexuan Cui <decui@...rosoft.com>
To:	Dexuan Cui <decui@...rosoft.com>,
	Vitaly Kuznetsov <vkuznets@...hat.com>
CC:	"olaf@...fle.de" <olaf@...fle.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: fix the race when querying & updating
 the percpu list

> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On Behalf
> Of Dexuan Cui
> >
> > Do we need to do tasklet_schedule() to make sure there are no events
> > pending? This is probably not a big issue as some other event will
> > trigger scheduling but in some corner cases it may bite. Same question
> > applies to the code below and to vmbus_close_internal().
> 
> Hi Vitaly,
> Thanks for spotting this!
> I think you're correct.
> I'll add tasklet_schedul() before the tasklet_enable() in the 2 places.

Sorry for the typo -- I meant "after" rather than "before".

Thanks
-- Dexuan