linux-kernel - Re: [PATCH v2 0/3] cpuacct: Show all detail stats in one file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160517083924.GA10776@gmail.com>
Date:	Tue, 17 May 2016 10:39:24 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Zhao Lei <zhaolei@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Subject: Re: [PATCH v2 0/3] cpuacct: Show all detail stats in one file

* Zhao Lei <zhaolei@...fujitsu.com> wrote:

>  1: Rewrite subject and changelog to fix typos and
>     make it more accurate.

So this is really annoying. In the previous review I suggested this:

 " - please fix the title of the patch: have a look at 'git log
     kernel/sched/cpuacct.c' how recent titles to that code look like. "

If you do what I suggested, you see this title:

    sched/cpuacct: Check for NULL when using task_pt_regs()

Yet you continued to submit using the tag I complained about:

    cpuacct: Show all detail stats in one file

Yes, it's a small detail that I could fix up, but this kind of inability to read 
very plain suggestions worries me.

And yes, if I look further, I see further signs of lack of care:

  In current code, we can get cpuacct data from severial files,

severial? How about at least running a spell checker over the text?

... and I haven't even looked at the code.

Thanks,

	Ingo