linux-kernel - [PATCH] ASoC: nau8825: Export I2C module alias information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 12:00:09 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	Kieran Bingham <kieran@...uared.org.uk>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	John Hsu <KCHSU0@...oton.com>, alsa-devel@...a-project.org,
	Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Anatol Pomozov <anatol.pomozov@...il.com>,
	Yong Zhi <yong.zhi@...el.com>,
	"Yang A\"" <yang.a.fang@...el.com>,
	kbuild test robot <lkp@...el.com>,
	Ben Zhang <benzh@...omium.org>
Subject: [PATCH] ASoC: nau8825: Export I2C module alias information

The I2C driver has an i2c_device_id array but that information isn't
exported to the module using the MODULE_DEVICE_TABLE() macro. So the
module autoloading won't work if the I2C device is registered using
OF or legacy board files due missing alias information in the module.

The issue was found using Kieran Bingham's coccinelle semantic patch:
https://lkml.org/lkml/2016/5/10/520

Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

---

 sound/soc/codecs/nau8825.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c
index 81fc97b07751..e988f89ef715 100644
--- a/sound/soc/codecs/nau8825.c
+++ b/sound/soc/codecs/nau8825.c
@@ -1493,6 +1493,7 @@ static const struct i2c_device_id nau8825_i2c_ids[] = {
 	{ "nau8825", 0 },
 	{ }
 };
+MODULE_DEVICE_TABLE(i2c, nau8825_i2c_ids);
 
 #ifdef CONFIG_OF
 static const struct of_device_id nau8825_of_ids[] = {
-- 
2.5.5