linux-kernel - Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvm1t50ad0j.fsf@hawking.suse.de>
Date:	Tue, 17 May 2016 18:02:36 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Joseph Myers <joseph@...esourcery.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Szabolcs Nagy <szabolcs.nagy@....com>,
	Yury Norov <ynorov@...iumnetworks.com>,
	<catalin.marinas@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <nd@....com>,
	<linux-arch@...r.kernel.org>, <linux-s390@...r.kernel.org>,
	<pinskia@...il.com>, <Prasun.Kapoor@...iumnetworks.com>,
	<broonie@...nel.org>, <linux-doc@...r.kernel.org>,
	<heiko.carstens@...ibm.com>, <agraf@...e.de>,
	<klimov.linux@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwidefsky@...ibm.com>, <Nathan_Lynch@...tor.com>,
	<christoph.muellner@...obroma-systems.com>,
	GNU C Library <libc-alpha@...rceware.org>
Subject: Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

Joseph Myers <joseph@...esourcery.com> writes:

> On Tue, 17 May 2016, Arnd Bergmann wrote:
>
>> I think it has become easier to override now and we just need to
>> update sysdeps/unix/sysv/linux/generic/bits/typesizes.h to set
>> 
>> #define __INO64_T_TYPE          __UQUAD_TYPE
>> #define __OFF64_T_TYPE          __UQUAD_TYPE
>> #define __OFF_T_MATCHES_OFF64_T        1
>> #define __INO_T_MATCHES_INO64_T        1
>> 
>> for new architectures (obviously not the ones that already use the
>> 32-bit types). I haven't tries this, so there may be other things
>> that are required.
>
> I think more than that would be needed to get struct stat to match and get 
> things aliased for that (which is presumably desirable).

Looking at sysdeps/unix/sysv/linux/generic/bits/stat.h, there is at
least blkcnt_t that differs between stat and stat64.  And you probably
want to alias statfs and statfs64 as well, ie. fs{blk,fil}cnt_t.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."